Bump MSRV to 1.37 #292
Merged
Bump MSRV to 1.37 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I know, futures/futures-util/futures-test with no-default-features are the only futures-related utilities that have been tested to compatibility with 1.36 and depend on pin-project. |
underscore_const_names requires 1.37
|
bors r+ See also #264 (comment) |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps MSRV to 1.37 because
underscore_const_namesrequires 1.37. This allows removing the build script.It's been more than a year since 1.37 was released, and most of the users of this crate depend on
futures_apithat requires 1.36 andasync_awaitthat requires 1.39. so bumping MSRV to 1.37 is probably no problem.Also, given that pin-project-lite's MSRV is 1.37 and the possibility of switching, most futures-related utilities require at least 1.37.
cc #264
Refs: #219